This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
#124 - Project Details Block Pattern #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The markup for this pattern was already provided by Bea but since it wasn't on a template I didn't include it in the original PR. Can you please check your markup against hers here to check that it all aligns? |
|
@MaggieCabrera I've updated the pattern to the provided markup. Let me know if that works. |
maneshtimilsina
suggested changes
Sep 5, 2023
patterns/project-details.php
Outdated
|
|
||
| ?> | ||
| <!-- wp:group {"align":"full","style":{"spacing":{"padding":{"top":"8vh","bottom":"8vh","right":"6vw","left":"6vw"}}},"backgroundColor":"base","layout":{"type":"constrained"}} --> | ||
| <div class="wp-block-group alignfull has-base-background-color has-background" style="padding-top:8vh;padding-right:6vw;padding-bottom:8vh;padding-left:6vw"><!-- wp:columns {"align":"wide","style":{"spacing":{"blockGap":{"top":"2em","left":"2em"}}}} --> |
There was a problem hiding this comment.
can we use presets instead here for the padding?
| <!-- wp:group {"align":"full","style":{"spacing":{"padding":{"top":"8vh","bottom":"8vh","right":"6vw","left":"6vw"}}},"backgroundColor":"base","layout":{"type":"constrained"}} --> | ||
| <div class="wp-block-group alignfull has-base-background-color has-background" style="padding-top:8vh;padding-right:6vw;padding-bottom:8vh;padding-left:6vw"><!-- wp:columns {"align":"wide","style":{"spacing":{"blockGap":{"top":"2em","left":"2em"}}}} --> | ||
| <div class="wp-block-columns alignwide"><!-- wp:column {"width":"15%"} --> | ||
| <div class="wp-block-column" style="flex-basis:15%"><!-- wp:paragraph {"style":{"typography":{"fontSize":"0.8rem","lineHeight":"1.4"}}} --> |
There was a problem hiding this comment.
same about font size presets here
MaggieCabrera
approved these changes
Sep 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots
Desktop
Mobile
Testing Instructions
Contributors
khleomix