Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature to exclude files in the check #408

Merged
merged 16 commits into from
Jul 3, 2024

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Jan 30, 2024

Fix partially #388

  • --exclude-files argument added in plugin check command
  • Filter wp_plugin_check_ignore_files added for ignoring files
  • Added Behat tests and unit tests
@ernilambar
Copy link
Member Author

@ernilambar ernilambar marked this pull request as ready for review January 31, 2024 11:34
@ernilambar
Copy link
Member Author

@mukeshpanchal27 Merge conflict has been fixed.

@ernilambar
Copy link
Member Author

@mukeshpanchal27 PR is synced with trunk and n.e.x.t has been removed as version.

@mukeshpanchal27
Copy link
Member

mukeshpanchal27 commented Apr 22, 2024

@swissspidy Do you know why the Behat test failed?

@swissspidy
Copy link
Member

As the error message says, the codecov token is missing, because this PR is originating from a fork. The tests are passing.

Copy link
Member

@davidperezgar davidperezgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's very nice this enhacement that will solve false positives.

Copy link

github-actions bot commented Jul 3, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <rabmalin@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: davidperezgar <davidperez@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@davidperezgar davidperezgar merged commit c7c428e into WordPress:trunk Jul 3, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants