Multi PHP + Multi Environment + Check all commits #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
- add the label - test dir is a dir (a tmp one) - no cert validation by default - simple WP by default
- support for labels - read latest commits
|
The code is not very beauty, but it should work... |
This was
linked to
issues
Mar 17, 2024
this is a first step to include some documentation inside the project, and not only in the handbook page.
pfefferle
reviewed
Jun 13, 2024
| @@ -38,6 +42,9 @@ export WPT_TABLE_PREFIX=${WPT_TABLE_PREFIX-wptests_} | |||
| # (Optionally) define the PHP executable to be called | |||
| export WPT_PHP_EXECUTABLE=${WPT_PHP_EXECUTABLE-php} | |||
|
|
|||
| # (Optionally) array of versions (like: 8.0+/bin/php8.0,8.1+/bin/php8.1) | |||
There was a problem hiding this comment.
Suggested change
| # (Optionally) array of versions (like: 8.0+/bin/php8.0,8.1+/bin/php8.1) | |
| # (Optionally) array of versions (like: 8.0=/bin/php8.0;8.1=/bin/php8.1) |
Maybe we should use the Link header syntax instead 8.0=/bin/php8.0;8.1=/bin/php8.1 because the + is also used by semantic versioning and might be used in the executable string.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Link
https://semver.org/#backusnaur-form-grammar-for-valid-semver-versions
|
|
||
| ## NodeJS installation | ||
|
|
||
| If you are using Debian / Ubuntu, install or update NodeJS 18 with this command: |
There was a problem hiding this comment.
Suggested change
| If you are using Debian / Ubuntu, install or update NodeJS 18 with this command: | |
| If you are using Debian / Ubuntu, install or update NodeJS 20 with this command: |
| # (Optionally) define the PHP executable to be called | ||
| export WPT_PHP_EXECUTABLE=${WPT_PHP_EXECUTABLE-php} | ||
|
|
||
| # (Optionally) array of versions (like: 8.0+/bin/php8.0,8.1+/bin/php8.1) |
There was a problem hiding this comment.
Suggested change
| # (Optionally) array of versions (like: 8.0+/bin/php8.0,8.1+/bin/php8.1) | |
| # (Optionally) array of versions (like: 8.0=/bin/php8.0;8.1=/bin/php8.1) |
|
|
||
| something like: | ||
|
|
||
| `8.0+/bin/php8.0,8.1+/bin/php8.1` |
There was a problem hiding this comment.
Suggested change
| `8.0+/bin/php8.0,8.1+/bin/php8.1` | |
| `8.0=/bin/php8.0;8.1=/bin/php8.1` |
| Use as much versions as you want, but it will take more time. The idea is to put all the versions offered to users. | ||
|
|
||
| ``` | ||
| export WPT_PHP_EXECUTABLE_MULTI=7.4+/bin/php7.4,8.3+/bin/php8.3 |
There was a problem hiding this comment.
Suggested change
| export WPT_PHP_EXECUTABLE_MULTI=7.4+/bin/php7.4,8.3+/bin/php8.3 | |
| export WPT_PHP_EXECUTABLE_MULTI=7.4=/bin/php7.4;8.3=/bin/php8.3 |
| @@ -65,9 +65,11 @@ function perform_operations( $operations ) { | |||
| foreach( $operations as $operation ) { | |||
| log_message( $operation ); | |||
| passthru( $operation, $return_code ); | |||
| /* THIS IS A TEMPORARY (or not) COMMENTED CODE | |||
|
|
||
| foreach( $php_multi_versions as $php_multi_version ) { | ||
|
|
||
| $php_multi_v = explode( '+', $php_multi_version ); |
There was a problem hiding this comment.
Suggested change
| $php_multi_v = explode( '+', $php_multi_version ); | |
| $php_multi_v = explode( '=', $php_multi_version ); |
| $WPT_PHP_EXECUTABLE_MULTI_ARRAY = array(); | ||
| if ( '' !== $WPT_PHP_EXECUTABLE_MULTI ) { | ||
|
|
||
| $php_multi_versions = explode( ',', $WPT_PHP_EXECUTABLE_MULTI ); |
There was a problem hiding this comment.
Suggested change
| $php_multi_versions = explode( ',', $WPT_PHP_EXECUTABLE_MULTI ); | |
| $php_multi_versions = explode( ';', $WPT_PHP_EXECUTABLE_MULTI ); |
| @@ -27,6 +27,7 @@ | |||
| $WPT_PREPARE_DIR = trim( getenv( 'WPT_PREPARE_DIR' ) ); | |||
| $WPT_SSH_OPTIONS = trim( getenv( 'WPT_SSH_OPTIONS' ) ); | |||
| $WPT_REPORT_API_KEY = trim( getenv( 'WPT_REPORT_API_KEY' ) ); | |||
| $WPT_PHP_EXECUTABLE_MULTI = trim( getenv( 'WPT_PHP_EXECUTABLE_MULTI' ) ) ? : ''; | |||
| @@ -164,6 +276,7 @@ | |||
| \$imagick_info = Imagick::queryFormats(); | |||
| } | |||
| \$env = array( | |||
| 'label' => '{$WPT_LABEL}', | |||
There was a problem hiding this comment.
there seems to be something broken with the indents?!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the Cloudfest Hackathon 2024 PR.
This PR solves:
The test-reporter will be upgraded to comply with these changes.