Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move NGINX-based services out of the API profile #4416

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented May 31, 2024

Fixes

Fixes #4289 by @dhruvkb

Description

This PR removes the use of the NGINX based services nginx and proxy from the api profile. This means they will no longer be created when invoking the api/up recipe.

Instead these services, along with the main API services web and cache are part of the api_extra profile and they can all be created by invoking the api/up-extra recipe (modelled after the catalog_dependencies approach).

This should speed up CI because of fewer services being built and raised.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (just catalog/generate-docs for catalog
    PRs) or the media properties generator (just catalog/generate-docs media-props
    for the catalog or just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
@dhruvkb dhruvkb added 🟨 priority: medium Not blocking but should be addressed soon 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: mgmt Related to repo management and automations labels May 31, 2024
@dhruvkb dhruvkb changed the title Move NGINX and proxy out of the API profile May 31, 2024
@dhruvkb dhruvkb marked this pull request as ready for review May 31, 2024 19:27
@dhruvkb dhruvkb requested review from a team as code owners May 31, 2024 19:27
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement to CI speed!

@AetherUnbound
Copy link
Contributor

Do any other CI jobs need to change in order to ensure these are built for release?

@dhruvkb
Copy link
Member Author

dhruvkb commented Jun 3, 2024

@AetherUnbound we are still building them and publishing them when appropriate, we just won't build them for the tests that don't need them.

Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, thanks for clarifying! Looks good!

@dhruvkb dhruvkb merged commit e003443 into main Jun 3, 2024
51 checks passed
@dhruvkb dhruvkb deleted the no_nginx_in_ci branch June 3, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: mgmt Related to repo management and automations
3 participants