Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frontend to include languages that do not have iso-639-1 codes #4363

Merged
merged 2 commits into from
May 21, 2024

Conversation

zackkrida
Copy link
Member

@zackkrida zackkrida commented May 20, 2024

Description

As discovered by a contributor in this issue, our translations of the Saraiki language were not appearing in production. I realized that the language was being filtered out of our valid translations because it does not have a langCodeIso_639_1 property in our code. This is because the language is part of the https://en.wikipedia.org/wiki/ISO_639-3 standard, which is essentially v3 of the list of international language codes, and our code was only including languages present in v1.

Saraiki appears to be the only language impacted by this change

Testing Instructions

just frontend/run i18n and just frontend/run dev locally and observe that the /skr path now works. You could also count and confirm that the locale chooser now has 61 languages instead of the 60 in production, with running something like [...document.querySelectorAll('.language option')].length in your browser's console.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (just catalog/generate-docs for catalog
    PRs) or the media properties generator (just catalog/generate-docs media-props
    for the catalog or just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
@zackkrida zackkrida requested a review from a team as a code owner May 20, 2024 19:15
@openverse-bot openverse-bot added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label May 20, 2024
@github-actions github-actions bot added the 🧱 stack: frontend Related to the Nuxt frontend label May 20, 2024
@zackkrida zackkrida added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix ♿️ aspect: a11y Concerns related to the project's accessibility and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels May 20, 2024
Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just noting that I had to run just frontend/run i18n locally first in order to get it to run before /skr showed up for me.

Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find! Interesting that only one language with a translator community is affected by this change :)

@zackkrida zackkrida merged commit 48e300d into main May 21, 2024
63 of 66 checks passed
@zackkrida zackkrida deleted the fix-iso-639-lang-codes branch May 21, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♿️ aspect: a11y Concerns related to the project's accessibility 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
4 participants