Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post title: Add example of the block #62955

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

MaggieCabrera
Copy link
Contributor

@MaggieCabrera MaggieCabrera commented Jun 28, 2024

What?

Add a basic example to the core/post-title block.

Part of #30029

Why?

Because it was showing empty before

How?

I define a viewport size for the example

Testing Instructions

Open the block inserter and search for the title block, hover over it and you'll see the example

Testing Instructions for Keyboard

Screenshots or screencast

Screenshot 2024-06-28 at 10 09 34
Copy link

github-actions bot commented Jun 28, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: MaggieCabrera <onemaggie@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@MaggieCabrera MaggieCabrera self-assigned this Jun 28, 2024
@MaggieCabrera MaggieCabrera added [Type] Enhancement A suggestion for improvement. [Block] Post Title Affects the Post Title Block labels Jun 28, 2024
Copy link
Contributor

@jameskoster jameskoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working for me :)

@MaggieCabrera MaggieCabrera merged commit 810f7e8 into trunk Jul 1, 2024
68 of 69 checks passed
@MaggieCabrera MaggieCabrera deleted the add-post-title-example branch July 1, 2024 09:45
@github-actions github-actions bot added this to the Gutenberg 18.8 milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Title Affects the Post Title Block [Type] Enhancement A suggestion for improvement.
2 participants