Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove changelog checks for branches other than trunk #62645

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Remove changelog checks for branches other than trunk #62645

merged 4 commits into from
Jun 18, 2024

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Jun 18, 2024 •
edited
Loading

What?

We shouldn't run these tests for branches such as #62641.

Why?

It will try to match the wrong PR (this one).

How?

Testing Instructions

Confirm the tests run here, confirm they are gone in #62641.

Testing Instructions for Keyboard

Screenshots or screencast

@ellatrix ellatrix requested a review from desrosj as a code owner June 18, 2024 08:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
@ellatrix ellatrix changed the title Remove/changelog test non trunk branches Jun 18, 2024
@ellatrix ellatrix added [Type] Bug An existing feature does not function as intended [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. and removed [Type] Bug An existing feature does not function as intended labels Jun 18, 2024
@ellatrix
Revert "test"
56a3c23 
This reverts commit 9cc41b1.
@github-actions GitHub Actions
Copy link

Flaky tests detected in 56a3c23.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9561419812
📝 Reported issues:
@ellatrix ellatrix merged commit c6e7ddb into trunk Jun 18, 2024
61 checks passed
@ellatrix ellatrix deleted the remove/changelog-test-non-trunk-branches branch June 18, 2024 09:01
@github-actions github-actions bot added this to the Gutenberg 18.7 milestone Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
2 participants
@ellatrix @youknowriad