Fix cherry-pick script, add missing --repo arg #62643
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ellatrix
force-pushed
the
fix/cherry-pick-comment-script
branch
from
f5b4989
to
0c445f2
Compare
bin/cherry-pick.mjs
Outdated
| @@ -380,15 +380,17 @@ function reportSummaryNextSteps( successes, failures ) { | |||
| function GHcommentAndRemoveLabel( pr ) { | |||
| const { number, cherryPickHash } = pr; | |||
| const comment = prComment( cherryPickHash ); | |||
| const repo = [ '--repo', 'WordPress/gutenberg' ]; | |||
There was a problem hiding this comment.
Does it fail because you have multiple origins or something?
There was a problem hiding this comment.
I have no idea why it's failing for me without explicitly passing it. Could be multiple remotes, yes. Or a different gh version? In any case, seems good to pass explicitly?
There was a problem hiding this comment.
@youknowriad Sorry, I'm completely unfamiliar with gh. Looks like it's using a security remote for me, but the origin remote is set to this one... 🤷♀️ I don't know why it's using that and how to change it.
There was a problem hiding this comment.
Anyway, we've hardcoded it in other places, so updated those too: 555040c
What?
When cherry-picking for Beta 2 and Beta 3, the script failed to comment and remove labels from PRs with the following error:
Additionally, the script removes and then re-adds the label. See example. So I deleted the line that adds the label back, I'm not sure why it's there.
Why?
How?
It turns out that the
--repoarg is missing.Testing Instructions
It was tested in #62641.
Testing Instructions for Keyboard
Screenshots or screencast