Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert escape-html package to TS #62586

Merged
merged 4 commits into from
Jun 14, 2024
Merged

convert escape-html package to TS #62586

merged 4 commits into from
Jun 14, 2024

Conversation

up1512001
Copy link
Contributor

@up1512001 up1512001 commented Jun 14, 2024 •
edited by sirreal
Loading

What?

This PR converts the escape-html package to TypeScript.

Why?

Ensures package is fully type checked.

How?

converted files to .ts
explicitly type functions and incorrectly-implied variables, based on @type, @param and @return comments

Testing Instructions

  • npm run test:unit -- packages/escape-html tests pass
  • npm run build:package-types returns a zero exit code

reference PR

Closes #61607
@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: up1512001 <up1512001@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
sirreal
sirreal approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@sirreal sirreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@sirreal sirreal added [Type] Code Quality Issues or PRs that relate to code quality [Package] Escape HTML /packages/escape-html labels Jun 14, 2024
@sirreal sirreal merged commit eb924d4 into WordPress:trunk Jun 14, 2024
65 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.6 milestone Jun 14, 2024
patil-vipul pushed a commit to patil-vipul/gutenberg that referenced this pull request Jun 17, 2024
@up1512001 @sirreal @patil-vipul
Escape-html: Convert package to TypeScript (WordPress#62586)
dc669ca 
Co-authored-by: jpstevens <jpstevens@git.wordpress.org>
Co-authored-by: sirreal <jonsurrell@git.wordpress.org>
Co-authored-by: up1512001 <up1512001@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Escape HTML /packages/escape-html [Type] Code Quality Issues or PRs that relate to code quality
2 participants
@up1512001 @sirreal