List View: Respect default shortcuts in modals #62479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -6 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6418738. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9465915441
|
|
I tested this in Gutenberg Playground PR, and it solves the issue. 👍 |
andrewserong
approved these changes
Jun 12, 2024
|
Thank you everyone for your reviews! |
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: mcsf <mcsf@git.wordpress.org> Co-authored-by: colorful-tones <colorful-tones@git.wordpress.org>
ellatrix
pushed a commit
that referenced
this pull request
Jun 18, 2024
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: mcsf <mcsf@git.wordpress.org> Co-authored-by: colorful-tones <colorful-tones@git.wordpress.org>
ellatrix
pushed a commit
that referenced
this pull request
Jun 18, 2024
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: mcsf <mcsf@git.wordpress.org> Co-authored-by: colorful-tones <colorful-tones@git.wordpress.org>
|
I just cherry-picked this PR to the wp/6.6-beta-3 branch to get it included in the next release: 30648f5 |
ellatrix
added
Backported to WP Core
ellatrix
pushed a commit
that referenced
this pull request
Jun 18, 2024
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: mcsf <mcsf@git.wordpress.org> Co-authored-by: colorful-tones <colorful-tones@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #61606
Fixes #62478
What?
This PR will respect the default behavior when keyboard events occur in a modal.
This fixes the issue where we couldn't select all the text in modals with
Ctrl + a, (command + a).Why?
This is because the event matches the shortcut for selecting all blocks at this point:
gutenberg/packages/block-editor/src/components/list-view/block.js
Line 290 in 2d34e2a
How?
I initially considered adding special handling for this shortcut. But it seemed more logical to me to just respect the default shortcuts for all events that occur inside a modal.
Testing Instructions
Ctrl + a, (command + a) in the text field.Ctrl + a, (command + a) in the text field.Screenshots or screencast
2d25e154695cd6e523a41bdca46d6855.mp4