Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance reporter: print the stdout/stderr from the worker #62316

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

jsnajdr
Copy link
Member

@jsnajdr jsnajdr commented Jun 5, 2024

Enhances the PerformanceReporter with onStdOut and onStdErr methods so that errors during the test run are reported even in CI where no other reporter is used.

Inspired by the dot reporter in Playwright: https://github.com/microsoft/playwright/blob/main/packages/playwright/src/reporters/dot.ts#L32-L42

@jsnajdr jsnajdr added the [Type] Performance Related to performance efforts label Jun 5, 2024
@jsnajdr jsnajdr self-assigned this Jun 5, 2024
Copy link

github-actions bot commented Jun 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jsnajdr!

@jsnajdr jsnajdr merged commit 0886185 into trunk Jun 5, 2024
67 of 68 checks passed
@jsnajdr jsnajdr deleted the add/perf-reporter-stdio branch June 5, 2024 07:36
@github-actions github-actions bot added this to the Gutenberg 18.6 milestone Jun 5, 2024
patil-vipul pushed a commit to patil-vipul/gutenberg that referenced this pull request Jun 17, 2024
…ss#62316)

Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Performance Related to performance efforts
2 participants