Components: Fix inaccessible disabled Buttons
#62306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Enhancement
This was referenced Jun 5, 2024
|
Size Change: -197 B (-0.01%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
mirka
force-pushed
the
components-button-eslint
branch
from
cb8e110
to
01d28f2
Compare
|
Flaky tests detected in f95b0b2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9768317028
|
mirka
commented
Jul 2, 2024
| @@ -326,6 +326,8 @@ function UnforwardedRangeControl( | |||
| <ActionRightWrapper> | |||
| <Button | |||
| className="components-range-control__reset" | |||
| // If the RangeControl itself is disabled, the reset button shouldn't be in the tab sequence. | |||
| __experimentalIsFocusable={ ! disabled } | |||
| disabled={ disabled || value === undefined } | |||
There was a problem hiding this comment.
There is a bug in the disabled logic here (value will never be undefined), extracted as a separate issue in #63061.
| @@ -58,6 +58,7 @@ function ListBox( { | |||
| id={ `components-autocomplete-item-${ instanceId }-${ option.key }` } | |||
| role="option" | |||
| aria-selected={ index === selectedIndex } | |||
| __experimentalIsFocusable | |||
There was a problem hiding this comment.
Disabled items in a popover menu should be perceivable.
| @@ -199,6 +199,7 @@ function UnconnectedDropdownMenu( dropdownMenuProps: DropdownMenuProps ) { | |||
| ? control.role | |||
| : 'menuitem' | |||
| } | |||
| __experimentalIsFocusable | |||
There was a problem hiding this comment.
Disabled items in a dropdown menu should be perceivable.
There was a problem hiding this comment.
Disabled toolbar buttons should always be perceivable.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mirka
added
[Type] Bug
mirka
commented
Jul 3, 2024
Comment on lines
+89
to
93
| // TODO: Should be focusable disabled, but adding `__experimentalIsFocusable` will trigger a | ||
| // focus bug when ToolbarButton is disabled via the `disabled` prop. | ||
| // Must address first: https://github.com/WordPress/gutenberg/issues/63070 | ||
| // eslint-disable-next-line no-restricted-syntax | ||
| disabled={ isDisabled } |
There was a problem hiding this comment.
We'll need to fix this one after #63070 is addressed.
| @@ -60,6 +60,7 @@ function UnforwardedToolbarButton( | |||
| className | |||
| ) } | |||
| isPressed={ isActive } | |||
| __experimentalIsFocusable | |||
There was a problem hiding this comment.
Disabled toolbar buttons should always be perceivable.
ciampo
approved these changes
Jul 3, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
* Components: Fix inaccessible disabled `Button`s * Fix in RangeControl * Fix in ToolbarButton * Fix unit test * List block: Try normalizing `disabled` * Revert "Fix in ToolbarButton" This reverts commit 2cea1eb. * Revert "List block: Try normalizing `disabled`" This reverts commit f95b0b2. * ToolbarButton: Defer fix * Revert "Fix unit test" This reverts commit ed03d97. * Add changelog * ToolbarButton: Add back focusable when not within ToolbarItem * Revert "Revert "Fix unit test"" This reverts commit 5f92fdc. Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #62080 and #62301
What?
Adds the restricted syntax lint rules for components to the
@wordpress/componentsfiles, and addresses the existing violations.Why?
As part of an effort to maintain accessibility standards
Testing Instructions
✅
npm run lint:jsshould pass