Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data views: Align page headers #62115

Merged
merged 3 commits into from
May 30, 2024
Merged

Data views: Align page headers #62115

merged 3 commits into from
May 30, 2024

Conversation

jameskoster
Copy link
Contributor

What?

Visually and structurally align data views page headers.

Why?

There are currently several disparities between the Patterns page header and other page headers in the Site Editor. This PR updates both Header and PatternsHeader components to bring them into alignment.

  • Title + Actions live in the same container with optional description below.
  • Header font size/weight matches (I could go either way on which size).
  • Description styling matches.
  • Action buttons use new 40px size rather than non-standard 36px.
  • Padding matches.

Before

Screenshot 2024-05-29 at 18 33 18 Screenshot 2024-05-29 at 18 33 26 Screenshot 2024-05-29 at 18 33 35

After

Screenshot 2024-05-29 at 18 31 50 Screenshot 2024-05-29 at 18 31 59 Screenshot 2024-05-29 at 18 32 09

Testing instructions

  • Navigate to Pages, Patterns, and Templates pages in the Site editor.
  • Ensure the headers match visually and structurally across.
@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond labels May 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 29, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
@jameskoster jameskoster enabled auto-merge (squash) May 30, 2024 10:34
@jameskoster jameskoster merged commit 1568b81 into trunk May 30, 2024
60 of 62 checks passed
@jameskoster jameskoster deleted the update/align-page-headers branch May 30, 2024 11:09
@github-actions github-actions bot added this to the Gutenberg 18.5 milestone May 30, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jun 4, 2024
@jameskoster @carstingaxion
Data views: Align page headers (WordPress#62115)
9084584 
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>
patil-vipul pushed a commit to patil-vipul/gutenberg that referenced this pull request Jun 17, 2024
@jameskoster @patil-vipul
Data views: Align page headers (WordPress#62115)
fde1285 
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Enhancement A suggestion for improvement.
2 participants
@jameskoster @jasmussen