Editor: Remove extra div container and unify the container between post and site editors #62016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st and site editors
youknowriad
added
the
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -2.55 kB (-0.15%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 4c37ff7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9252326076
|
Something isn't right here: meta.mp4When editing a long post the metabox appears to be floating in the middle of it, and the post styles (background color at least) disappear beneath it. |
|
Good catch @jameskoster I think I fixed it in the last commit. |
jameskoster
approved these changes
May 28, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
…st and site editors (WordPress#62016) Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…st and site editors (WordPress#62016) Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Small refactoring PR that removes and unifies
edit-post-visual-editorandedit-site-visual-editorcontainers. There's already a sharededitor-visual-editorcontainer. So this PR removes that extra DOM node and moves some styles around. I'm keeping the classnames mostly for backward compatibility though.Testing Instructions
1- Ensure that the editor looks properly with and without metaboxes (with and without iframe).
2- Ensure that the site editor looks properly.
3- Ensure that stylebook looks properly.