Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gutenberg/gutenberg-coding-standards licensing issues #61913

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

anton-vlasenko
Copy link
Contributor

@anton-vlasenko anton-vlasenko commented May 23, 2024

What?

This PR:

  1. removes third-party code from the gutenberg/gutenberg-coding-standards (GBCS) package and removes unused code;
  2. switches GBCS to the GPL-2.0-or-later license as it provides more freedoms and access to licensees than MIT-license code.

Why?

Ensure the package does not use any third-party code.

How?

  • change the license to GPL-2.0-or-later;
  • Remove third-party code from the SinceTagSniff::find_docblock() method;
  • Remove third-party code from the SinceTagSniff::is_function_call() method;
  • Remove the SinceTagSniff::find_hook_docblock() method and add the new find_previous_line_token() method (refactoring);
  • Fix typo in the SinceTagSniff::process() method;
  • Remove unused code from bootstrap.php and make variables use snake case;

Testing Instructions

  1. Review the code changes and ensure that all CI jobs pass successfully.
  2. Navigate to test/php/gutenberg-coding-standards/.
  3. Run composer update.
  4. Run composer run check-all.
  5. Ensure there are no errors in the console.

Testing Instructions for Keyboard

Screenshots or screencast

@anton-vlasenko anton-vlasenko added the [Type] Build Tooling Issues or PRs related to build tooling label May 23, 2024
Copy link

github-actions bot commented May 23, 2024

Flaky tests detected in 2716212.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9214390920
📝 Reported issues:

@anton-vlasenko anton-vlasenko force-pushed the fix/remove-3rd-party-code-from-gbcs branch from 5d89eb5 to 71c3429 Compare May 27, 2024 15:59
@anton-vlasenko anton-vlasenko force-pushed the fix/remove-3rd-party-code-from-gbcs branch from 0d70552 to 4ce49e0 Compare June 5, 2024 17:34
@WordPress WordPress deleted a comment from github-actions bot Jun 5, 2024
Copy link

github-actions bot commented Jun 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: anton-vlasenko <antonvlasenko@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

- remove third-party code from the SinceTagSniff::find_docblock() method;
- remove third-party code from the SinceTagSniff::is_function_call() method;
- remove the SinceTagSniff::find_hook_docblock() method and add the new find_previous_line_token() method (refactoring);
- fix typo in the SinceTagSniff::process() method;
- remove unused code from bootstrap.php and make variables use snake case;
@anton-vlasenko anton-vlasenko force-pushed the fix/remove-3rd-party-code-from-gbcs branch from 06edf90 to f734bfd Compare June 24, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling
1 participant