Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block bindings: Remove not needed breaks in gutenberg_block_bindings_replace_html #61660

Merged
merged 2 commits into from
May 14, 2024

Conversation

cbravobernal
Copy link
Contributor

What?

Quick PR that removes unreachable code.

We can include this too in #61236 backport @SantosGuillamot

Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/compat/wordpress-6.5/blocks.php
Copy link

github-actions bot commented May 14, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>
Co-authored-by: dmsnell <dmsnell@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks benign; I'm curious how these appeared, but it doesn't matter. This is a positive change.

@cbravobernal
Copy link
Contributor Author

cbravobernal commented May 14, 2024

Looks benign; I'm curious how these appeared, but it doesn't matter. This is a positive change.

They are also in Core I'm afraid.
https://github.com/WordPress/wordpress-develop/blob/c3a4e8bbe55427b444a269de07e28189bfb9c60b/src/wp-includes/class-wp-block.php#L384

@cbravobernal cbravobernal merged commit b819a5f into trunk May 14, 2024
62 checks passed
@cbravobernal cbravobernal deleted the refactor/block_bindings_php_review branch May 14, 2024 17:22
@github-actions github-actions bot added this to the Gutenberg 18.4 milestone May 14, 2024
@cbravobernal cbravobernal self-assigned this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block bindings [Type] Code Quality Issues or PRs that relate to code quality
2 participants