Update image role description text to fix spacing. #60338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -36 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
t-hamano
reviewed
Apr 1, 2024
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Good attention to detail, and thank goodness for fragments! Applied. |
It's not always great that the link breaks onto two lines, but in this case I would think the simpler solution — no special treatment for this description — here is the better one. It's an advanced aspect, regardless, and a long help text. Improvements from this point onward could/should be editorial, IMO. Thank you for the contributions 🙏 |
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
* Update image role description text to fix spacing. * Update packages/block-editor/src/hooks/anchor.js Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> * Include suggestion. --------- Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The help text for the image role is poorly wrapped and lacks a space:
This PR removes the separate style for the link URL, for consistency, and adds a space: