Refactor Link UI States #59762
Merged
Refactor Link UI States #59762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -44 B (0%) Total Size: 1.73 MB
ℹ️ View Unchanged
|
|
Thanks for the ping, @draganescu! @jeryj, can you rebase this on top of the latest trunk so we don't miss any new changes when testing? 🙇 |
The only reason this was necessary was to decide if we should autofocus or not. We can determine that based on the click event that sets the addingLink state. Reverting back to one state.
jeryj
force-pushed
the
try/simplify-link-ui-states
branch
from
63b187a
to
8d636dc
Compare
|
I've rebased this, so it's ready for another review. |
Mamaduka
added
the
[Feature] Link Editing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Simplifies logic from #59635 for:
Why?
Code simplicity/ease of understanding.
How?
The editing and creating states were distinctions added to decide if we should autofocus or not. There is only one instances we need to be able to autofocus: When a user clicks an existing link. This happens within a click handler, that can only exist if the user has a link to click. There is an
openBystate we already have in use, and we can store information about this within the openBy state to determine if we should autofocus or not.Testing Instructions
There should be no functional difference between trunk and this PR.
Testing Instructions for Keyboard
Screenshots or screencast