Block Hooks: Display toggle for hooked blocks added via filter #59396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +945 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Feb 27, 2024
ockham
added
Backport to WP 6.6 Beta/RC
16 tasks
michalczaplinski
approved these changes
Feb 28, 2024
sirreal
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
This change tests as expected 👍
Are those limitations problematic? Will it make things even more confusing to users that the toggles now show up for blocks added by filters, but only if the template has modifications? Or is it still a net win?
I don't feel sufficiently well informed to opine on this.
I left a comment on this change for consideration. It's not blocking.
ockham
deleted the
fix/block-hooks-toggle-include-ignored-hooked-blocks
branch
youknowriad
pushed a commit
that referenced
this pull request
Mar 4, 2024
Show the Block Hooks toggle for hooked blocks that were added via the `hooked_block_types` filter (rather than at block registration time, i.e. via the `blockHooks` field in `block.json`), by evaluating the anchor block's `ignoredHookedBlocks` metadata attribute. (This attribute is only present if the containing template/part/pattern has user modifications.) Co-authored-by: ockham <bernhard-reiter@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org> Co-authored-by: michalczaplinski <czapla@git.wordpress.org> Co-authored-by: sirreal <jonsurrell@git.wordpress.org>
|
I just cherry-picked this PR to the update/packages-6.5-rc1 branch to get it included in the next release: 2bc516a |
youknowriad
added
Backported to WP Core
youknowriad
pushed a commit
that referenced
this pull request
Mar 4, 2024
Show the Block Hooks toggle for hooked blocks that were added via the `hooked_block_types` filter (rather than at block registration time, i.e. via the `blockHooks` field in `block.json`), by evaluating the anchor block's `ignoredHookedBlocks` metadata attribute. (This attribute is only present if the containing template/part/pattern has user modifications.) Co-authored-by: ockham <bernhard-reiter@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org> Co-authored-by: michalczaplinski <czapla@git.wordpress.org> Co-authored-by: sirreal <jonsurrell@git.wordpress.org>
andrewserong
removed
the
Backport to Gutenberg RC
|
I've just removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Show the Block Hooks toggle for hooked blocks that were added via the
hooked_block_typesfilter (rather than at block registration time, i.e. via theblockHooksfield inblock.json).Why?
To improve UX. It is otherwise somewhat surprising for users that the toggle doesn't show up.
How?
By evaluating the anchor block's
ignoredHookedBlocksmetadata attribute. This attribute is only present if the containing template/part/pattern has user modifications, which causes the following limitations:Limitations
Note that this only works for templates/parts/patterns that have been modified by the user.
Furthermore, note that for hooked blocks added by filters, the client does not know their relative positions, so when enabling the toggle, it will default to inserting the hooked block after the current (anchor) block.
Question
Are those limitations problematic? Will it make things even more confusing to users that the toggles now show up for blocks added by filters, but only if the template has modifications? Or is it still a net win?
Testing Instructions
trunk, or the latest WP 6.5 Beta.To ensure that this is indeed due to this PR, switch to
trunkand verify that the Plugins panel is absent for the Like Button.Screenshots or screencast