Revert "Navigation: Refactor mobile overlay breakpoints to JS (#57520)" #59149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
added
[Type] Bug
cbravobernal
requested review from
scruffian,
getdave,
DAreRodz and
fabiankaegy
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -148 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2a95460. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7964103166
|
fabiankaegy
approved these changes
Feb 18, 2024
|
@c4rl0sbr4v0 Actually looking at the failed teste it does seem like they might be related. I'm not certain of whether it is simply tests that test implementation vs functionality because in my manual testing it is working fine for me 🤔 |
I'll take a look at them. |
gziolo
added
the
[Priority] High
This reverts commit 1b75cf6.
cbravobernal
force-pushed
the
fix/navigation-flash-on-load
branch
from
6ca3d8d
to
cd4e8da
Compare
|
Tests are green now. @fabiankaegy the "always mobile" option was not working. |
|
Ahhh cool :) All good on my end now 👍 |
|
@youknowriad @getdave Flagging this one to you for the next round of backports |
getdave
pushed a commit
that referenced
this pull request
Feb 20, 2024
…" (#59149) Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: DAreRodz <darerodz@git.wordpress.org> Co-authored-by: huubl <huubl@git.wordpress.org> Co-authored-by: cbirdsong <cbirdsong@git.wordpress.org> Co-authored-by: tomxygen <tomxygen@git.wordpress.org>
|
I just cherry-picked this PR to the cherry-pick-beta-2 branch to get it included in the next release: 27da58c |
getdave
removed
the
Backport to WP 6.6 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Feb 20, 2024
…" (#59149) Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: DAreRodz <darerodz@git.wordpress.org> Co-authored-by: huubl <huubl@git.wordpress.org> Co-authored-by: cbirdsong <cbirdsong@git.wordpress.org> Co-authored-by: tomxygen <tomxygen@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1b75cf6.
What?
Fixes #58724
Why?
Moving the visibility of the navigation menu to JS instead of relying in CSS is causing a flash on slow networks.
How?
Testing Instructions