Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks: refactor deletion warnings dialog #58952

Merged
merged 9 commits into from
Feb 22, 2024
Merged

Blocks: refactor deletion warnings dialog #58952

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
af34045
Refactor block removal warnings to use a callback, and move them to t…
glendaviesnz Feb 12, 2024
84057aa
Refactor block removal callback rules
talldan Feb 20, 2024
08e5325
Add in an early return when there are no block removal rules
talldan Feb 20, 2024
0664bfb
Reflect existing `trunk` behavior of only showing one warning message
talldan Feb 21, 2024
d57f1cb
Restore original e2e test
talldan Feb 21, 2024
c4849b3
Fix a few bugs
talldan Feb 21, 2024
b2925d7
Finish sentence
talldan Feb 21, 2024
01e8781
Avoid trying to render `BlockRemovalWarnings` on mobile
talldan Feb 22, 2024
dd72cd7
Update test
talldan Feb 22, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Finish sentence
  • Loading branch information
@talldan
talldan committed Feb 22, 2024
commit b2925d7747e70b2e0766d44184cf763650126dc6
2 changes: 1 addition & 1 deletion packages/editor/src/components/block-removal-warnings/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const BLOCK_REMOVAL_RULES = [
},
{
// Pattern overrides.
// The warning is only shown when the user manipulates
// The warning is only shown when the user edits a pattern.
postTypes: [ 'wp_block' ],
callback( removedBlocks ) {
const removedBlocksWithOverrides = removedBlocks.filter(
Expand Down
Loading