Removing Reakit as a dependency #58631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewhayward
added
[Type] Task
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNIf you're a Core Committer, use this list when committing to GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +572 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
ciampo
reviewed
Feb 2, 2024
There was a problem hiding this comment.
Should we also make sure that there are no more references to reakit in the code?
I could spot a few across these files:
- https://github.com/WordPress/gutenberg/blob/7946a0de0bd9b36f435a6913624fcaf626fecd3b/packages/edit-site/src/components/page-patterns/grid-item.js
- https://github.com/WordPress/gutenberg/blob/773f4d3dcfb9ae9d1608f436f9b5cf8c7db622e9/packages/components/src/utils/hooks/use-update-effect.js
- https://github.com/WordPress/gutenberg/blob/c777886d29c77da45f003e081a2691fecf2f37c2/packages/components/src/divider/README.md
- https://github.com/WordPress/gutenberg/blob/1ba116b01f986c5945b40d5eecd77c3bd1159df5/packages/components/src/context/wordpress-component.ts
mirka
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Reakit is dead, long live Ariakit! 🚀
Should we also make sure that there are no more references to
reakitin the code?
Good catch! I'm fine with the code comment URL stuff since they're references to things in the Reakit codebase that possibly don't apply in the current Ariakit code. Maybe there's value in preserving the original intent there. But the Divider readme, we should definitely update!
I did check, and as @mirka points out, they're all in comments, so I didn't think it appropriate or necessary to remove them. But happy to do so if we collectively think otherwise.
Probably should have happened as part of #55622, but yes, that's long outdated at this point. |
|
Some of those links are 404ing though, so probably there is still value in either updating them to the right URL (or the ariakit version of it), or removing them |
I've updated the Reakit-related Github links, so that they at least work. The only link I didn't update is in |
I don't know if Gutenberg uses that |
Thanks @diegohaz – I've removed the comment, but left the |
|
Flaky tests detected in 448fde8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7783452646
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Reakit as a dependency. Closes #53278.
Why?
See #53278.
How?
reakitis removed as a dependency frompackage.json(and by extensionpackage-lock.json). Additionally, the ESLint import rule is removed from.eslintrc.js.Testing Instructions
Everything should build as expected, including Storybook.