Move Shadow controls to Border panel #58466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -15 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e4c942d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7798314771
|
vcanales
force-pushed
the
move-shadows-to-border-panel
branch
from
829ae8a
to
e2aabd6
Compare
vcanales
force-pushed
the
move-shadows-to-border-panel
branch
from
19521df
to
3081a05
Compare
packages/block-editor/src/components/global-styles/border-panel.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/global-styles/border-panel.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/global-styles/border-panel.js
Outdated
Show resolved
Hide resolved
6 tasks
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNIf you're a Core Committer, use this list when committing to GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
vcanales
force-pushed
the
move-shadows-to-border-panel
branch
from
17381f7
to
77e9101
Compare
|
An aside, but we should not enable box shadow control by default. Does |
We can do that on each supported block, but I've also disabled it in the Border panel itself (14095e1), which could then be overridden — ie. set to I am wondering why, though! I would appreciate a reference on what to consider a default control in the future. |
It can be a default control in a sense that it's available, shadow is not something every site will use — having it front and center every time you click on a button is a bit much. It's the same reasons we don't have the line-height control visible all the time for Heading and Paragraph blocks. |
vcanales
force-pushed
the
move-shadows-to-border-panel
branch
from
13cb245
to
b0e81f4
Compare
|
I think this is ready for another review. Screenshot
@joen, @madhusudhand made an excellent point in that we were displaying the Border box controls directly under the "Box & Shadow" label, with no specification of what the control is for, so I've added a "Border" label only visible when Shadow controls are available:
I'm wondering if the label is fine as "Border" or if we should use something even more specific, like "Border box", which is what the component for those controls is called. |
madhusudhand
reviewed
Feb 6, 2024
madhusudhand
force-pushed
the
move-shadows-to-border-panel
branch
2 times, most recently
from
b160ff0
to
b51e344
Compare
madhusudhand
approved these changes
Feb 6, 2024
madhusudhand
force-pushed
the
move-shadows-to-border-panel
branch
from
6612b21
to
e4c942d
Compare
@richtabor Similar to other controls, it is addressed and works in block styles, but not in global styles. (it is also same for other controls such as |
MaggieCabrera
added
the
Global Styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Moves the Box shadow controls into the Border panel, in order to keep the "Effects" panel name free for possible future additions via the Interactivity API.
Screenshot