Add a timezone offset value for display purposes #56682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.5/script-loader.php ❔ lib/load.php |
|
Size Change: +13 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
I'll remove myself as a review as this isn't really my domain. Instead, I'm adding a few more folks (following suggestions from GitHub) who may be better suited to take a good look |
|
@Mamaduka hi. Any familiarity with compat files? When you have a chance, some help would be greatly appreciated 🙏 |
Mamaduka
reviewed
Dec 18, 2023
There was a problem hiding this comment.
@afercia, I wonder if we should just do the conversion on the client side since the human-readable offset is only used when displaying the text. The libraries on the client and server can accept unformatted values.
P.S. The new compat file looks good to me. There's already a gutenberg_update_wp_date_settings filter in WP 6.4; we should probably remove it to avoid double filtering.
afercia
force-pushed
the
fix/timezone-offset-display-value
branch
from
6912663
to
6df0c78
Compare
|
@Mamaduka thanks for your review.
Yes that's an option. I'd think it's simpler to just provide the value and use it directly. Otherwise we should make the conversion in two different places or provide a small utility and use it in two places anyways. And in the tests.
I have no idea how the compat files mechanism works. Glad to remove it if necessary, just let me know. |
afercia
force-pushed
the
fix/timezone-offset-display-value
branch
from
79abf23
to
604a89f
Compare
SergeyBiryukov
approved these changes
Dec 21, 2023
afercia
force-pushed
the
fix/timezone-offset-display-value
branch
from
604a89f
to
47bb3e5
Compare
afercia
force-pushed
the
fix/timezone-offset-display-value
branch
from
47bb3e5
to
781b916
Compare
|
Rebased on top of latest trunk. |
|
Thank you for working on this and the associated backport to WP Core. I added it to the PHP Sync Tracking Issue. Once the code is merged into WP Core we'd be grateful if you could:
Thank you in advance 🙇 |
|
Trac ticket for Core patch: https://core.trac.wordpress.org/ticket/60105 🙇🏻 |
youknowriad
added
Backported to WP Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56254
I'm not very familiar with how to handle compat files. This is only a first pass to showcase a possible solution, please do not merge yet.
What?
The timezone offset value is displayed 'as is stored' with decimals instead of minutes. E.g.
5.75instead of5.45.As such, the stored value is not what we want for display purposes.
Why?
We need to display a correct timezone with minutes.
How?
wp.date.setSettings.formattedOffsetto thetimezonesettings, this new value is meant for display purposes.Testing Instructions
UTC+5:45.Testing Instructions for Keyboard
Screenshots or screencast