-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Block Toolbar Semantics/Accessibility #54513
Closed
Closed
Changes from 1 commit
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
8e521f7
Move Selected Block Tools into the header toolbar in the DOM but pres…
jeryj deacf25
Render selected block toolbar as a fill within a slot in the header t…
jeryj 4ede8a7
Pass isFixed to ContextualToolbar for styling
jeryj 45ebf2f
Add block popover to edit site header slot
jeryj fea3c9f
Add classname to selected block tools slot and use bubblesVirtually
jeryj ed8541b
Move lastFocus into redux store
jeryj 7728101
Fix comment of getLastFocus method
jeryj 271b0eb
Add inline rich tools to header popover
jeryj 647ecf5
Use menubar role to group header toolbars
jeryj 0f34d47
Add focusEditorOnEscape to NavigableToolbar to return focus to editor
jeryj 55cbde4
Consolodate block tools into one fill component and conditionally ren…
jeryj 6162985
Remove absolute positioned block tool hacks
jeryj b749291
Add selected block toolbar slot to widget header
jeryj 1cdf89e
Allow block toolbar to scroll if not enough space
jeryj c15c5b1
Scroll toolbar
jeryj 1e54077
isBlockToolsCollapsed state and styles for edit site header
jeryj 85ac216
Block toolbar scroll on edit site header
jeryj a6e542e
Only allow block tool collapse to impact large viewports
jeryj 818bdf7
Make room for top toolbar on site editor at smaller screens
jeryj 2364439
Display fixed block toolbar at smaller screen sizes in site editor
jeryj 7551136
Fix select mode in top toolbar
jeryj 6c3dcdf
Add visually hidden aria-describedby instructions for how to use the …
jeryj ab1c29e
Fix e2e test for shift + tab to editor chrome
jeryj accedb5
Remove unnecessary test related to shift+tab focusing the block toolbar
jeryj e24d203
Replace tabbing through block test with arrow through blocks test
jeryj da3a1ea
Refactor keyboard navigable blocks test to match new behavior
jeryj 484f118
Replace shift+tab with alt+F10 to focus toolbar in tests
jeryj 6addc4f
Pass keydown listener into navigable toolbar instead of removing bubb…
jeryj 9cd01cf
Fix test locator when multiple options buttons are in the header
jeryj 6c80738
Fix test: return to block via escape keypress
jeryj 6bed696
Resizeable box (for resizing cover block) should use after block popo…
jeryj 5ddeb0b
Fix: Add setListViewToggleButton ref back into site edit header
jeryj 6ebb4d9
Update roving toolbar test to use alt+f10 and escape
jeryj cc0b4dd
Fix selected block tools back compat file path
jeryj bcfb65b
Clarify getLastFocus description
jeryj e96401d
Update docs
jeryj f1066c4
Refactor selectors on selected block popover and empty block inserter
jeryj 92f95f1
Refactoring of selected block tools... continued
jeryj e565a8a
Refactoring continued
jeryj b1da15c
Refactor to use useSelectedBlockToolProps
jeryj bf5e941
Refactor to remove data from useSelectedBlockToolProps that were not …
jeryj 8072e7a
Remove props being overriden in BlockPopover
jeryj 267863a
Fix incorrect block popover positioning
jeryj ba354bd
Hide block tools popover behind post header
jeryj d2167e7
Block tools should be behind site editor header
jeryj d23a4cf
Hide block tools behind header refactoring
jeryj 60a8d69
Only show collapse button if hasFixedToolbar
jeryj bc03bd1
Fix positioning bug when center tools are collapsed
jeryj 3788c00
Bring back the top toolbar on post editor
jeryj 07ac3b8
Fix widgets top toolbar/block tools slide-behind-header hacks
jeryj fa398e1
Fixing more positioning hacks with flexbox
jeryj c3b650c
Add removed __unstableCoverTarget prop back to empty block popover
jeryj 8d57813
Remove unnecessary test
jeryj 4c662de
Handle escape on toolbar via toolbar event listener instead of children
jeryj 0c54480
Add keyboard navigation test to cover escape and alt+10 keypresses
jeryj a291e1f
Added changelog for popover shiftPadding prop
jeryj c12381e
Switch to object notation to avoid bugs like I introduced where the o…
jeryj 1449b4a
Fix editor canvas locator evaluation
jeryj 9cc91d9
Show focus ring on document tools
jeryj 3a96e02
Fix check for selectedBlockToolsRef
jeryj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Block tools should be behind site editor header
- Loading branch information
commit d2167e75c6c6d09d287535892346bd0f7f0d671a
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯