Add missing dependency of @wordpress/patterns on @babel/runtime
#54118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build code transformations can introduce dependencies on packages such as @wordpress/element and @babel/runtime. These need to be declared if the package is to function correctly with yarn's p'n'p or pnpm with hoisting disabled. - @wordpress/patterns depends on @babel/runtime (fixes WordPress#54115)
|
Ping @glendaviesnz, @kevin940726, @andrewserong as people responsible for adding this in #53161, and @gziolo since you merged the similar #41486 for me recently. |
Yes, we should start using peer dependencies more now that the Gutenberg project switched to Node 16 and npm 8. We probably need to stop using legacy peer deps flag first: Line 3 in f454434 |
gziolo
added
[Type] Code Quality
gziolo
approved these changes
Sep 2, 2023
jamestitus299
added a commit
to jamestitus299/gutenberg
that referenced
this pull request
Sep 4, 2023
…ntime` (WordPress#54118)" This reverts commit 3b114f7. restore changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add missing dependency of
@wordpress/patternson@babel/runtimeWhy?
Build code transformations can introduce dependencies on packages such as @wordpress/element and @babel/runtime. These need to be declared if the package is to function correctly with yarn's p'n'p or pnpm with hoisting disabled.
@wordpress/patternsis missing a dependency on@babel/runtime#54115)How?
Adding the missing dependencies. Normally I'd probably have done the
@babel/runtimedep as a peer dep, but I see you use a normal dependency everywhere else so I followed along.Testing Instructions
yarn add <package>@file:/path/to/gutenberg/packages/<package>orpnpm add <package>@file:/path/to/gutenberg/packages/<package>to point yarn or pnpm at the locally built version of the package.