Add support for registering commands without icons #53647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Enhancement
|
Size Change: +130 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Aug 15, 2023
Mamaduka
reviewed
Aug 15, 2023
|
@Mamaduka do you know what this failure is? |
|
@richtabor yes, you should run |
Thanks, noted! |
|
Flaky tests detected in a28b625. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5870052669
|
|
@Mamaduka pinged ya for another quick double-check. Thanks! |
Mamaduka
approved these changes
Aug 15, 2023
lipemat
added a commit
to lipemat/types-js-boilerplate
that referenced
this pull request
Sep 11, 2023
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #53193 by removing the requirement for commands to register icons. If the icon does not support the command, it probably shouldn't be required as part of the registration.
Testing Instructions
cogicons.Screenshots or screencast