Global styles revisions: add a reset to default revision #52965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm wonder if this will make the "Reset to default" button in the drop down redundant? 
Maybe if these changes went through, it might be okay to leave both in there for a while for easy access? 🤷🏻 |
|
Love the idea! I can take this for a proper spin tomorrow 🙂
Being able to access from two places sounds good to me, especially since it's nice to be able to reset things quickly if you need to without having to go digging? |
ramonjd
added
[Type] Enhancement
|
Size Change: +116 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
There's a bug here somewhere:
For some reason the reset revision is lost. Edit: fixed in f3e39e2 |
|
Flaky tests detected in f3e39e2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5710403931
|
|
Thanks for opening the PR, this is a good idea imo. I appreciate it's not technically a 'revision' but I suspect users will interpret it as one, so we can keep special treatment to a minimum. For example the button label can remain "Apply" instead of "Reset to defaults". The timeline item label can just be "Default styles" – I think this would harmonise with the "Reset to defaults" action in the Styles panel header. |
- Ensure that any undefined properties, e.g., styles, settings, are set as empty objects so that any theme defaults are correctly displayed by default
ramonjd
force-pushed
the
try/global-styles-revisions-add-reset-revision
branch
from
3059f40
to
f3e39e2
Compare
andrewserong
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Nice work, this is testing well for me:
✅ Displays correctly when there's at least 1 revision
✅ For themes with heaps and heaps of revisions, it displays at the very bottom of the list
✅ Selecting revisions works as usual
✅ Resetting to the default styles works as expected
2023-08-03.12.05.43.mp4
This LGTM and feels like a nice addition to the UI! ✨
|
Thanks for testing @andrewserong! |
ramonjd
added a commit
that referenced
this pull request
Aug 3, 2023
…e are more than 0 revisions since there is the default with which we can compare the single revision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #52951
What?
Inserting a reset object as the first "revision" to reset to theme defaults.
Originally spoken about in #50089 (comment)
Why?
Testing out reducing any perceived confusion explained in #52951
Basically we are trying to find a way to show the revisions panel after a the first change, instead of two changes.
Reason behind the two change rule here: #50089 (comment)
How?
Adding a 'fake' revision to the end of the revisions UI list.
TODO
Testing Instructions
Screenshots or screencast
2023-07-31.13.54.33.mp4