Refactor ToolbarGroup to Typescript #50262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tch the global styles controller (#50270) * Ensuring that the revisions endpoint for global styles revisions matches the permissions for the global styles custom post type controller * Replacing with the same check as WP_REST_Global_Styles_Controller->get_item_permissions_check, since this is the check against the original global style custom post * translation domain * Fixed copy
…initions in layout settings (#50268)
* Mobile - Adds initial useEditorWrapperStyles hook * Mobile - Update useEditorWrapperStyles hook to take into account custom marginHorizontal values * Mobile - useEditorWrapperStyles hook - Remove helper tests and exports * Mobile - useEditorWrapperStyles - Move max width values from the SCSS styles to the JavaScript side and update tests * Mobile - useEditorWrapperStyles - Update helpers to use an options object param instead of first level params * Mobile - useEditorWrapperStyles - Update wrapperStyles logic to unify canvasStyles logic
* Fix site logo preview image size with long filenames * hardcode width value
* Introduce new PluginTemplateSettingPanel slot * Apply suggestions from code review Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com> --------- Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com>
* Better labels for sidebars and close buttons. * Add back sidebar to the Settings keyboard shortcut description.
* Remove custom padding for tertiary buttons * changelog
* Mock `ActionSheetIOS` library * Add setup picker test helper * Use `setupPicker` in gallery integration tests * Add style mock * Add test to check correct media options picker in Gallery block
… to simplify the code and apply it to the Widgets Editor. (#50344)
* Add focus ring and keydown event to enter site editor The site editor is an iframe, which doesn't reliably emit focus events. To work around this, when the blur and focus events are emitted on the `useTabNav` from `useWritingFlow` on the iframe editor, the iframe component can set a `.is-focused` classname on the iframe to show a visual outline. The onClick event listener doesn't work on the iframe to handle a spacebar or enter keypress, so we had to add an onKeyDown listener for this as well. * Set W logo as a Go back to dashboard link when site editor navigation is open We need the W logo element tag to stay the same between both the navigation open and closed states so that the component doesn't remount and beak the animation. To do this, we have to set an `href` to force the <Button> component to stay as an <a>. * Use CSS var for border width focus and calc * Fix missing - (negative) in the offset * refactor to remove many conditionals * Refactor how to pass props to Iframe * Lint js --------- Co-authored-by: scruffian <ben@scruffian.com>
* Fix exec command in CI Use -T instead of --no-TTY. The latter doesn't work. Fix unit test that was failing on trunk.
margolisj
requested review from
spacedmonkey,
noahtallen,
kevin940726,
ntwb,
nerrad,
gziolo,
ryanwelcher,
draganescu,
talldan,
noisysocks,
tellthemachines,
adamziel,
getdave,
ellatrix,
michalczaplinski,
geriux,
mmtr,
ajlende,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Convert the ToolbarGroup component to TypeScript.
Why?
This PR is needed as part of an effort to convert ToolbarGroup to TypeScript. As mentioned in #35744 .
How?
By adding types to ToolbarGroup.
Testing Instructions
Create or otherwise open a post
Add a block that would have some toolbar controls (e.g. Image)
Expected: Toolbar buttons should fundamentally work the same as before: