Add spacing tools to time to read block #49392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Enhancement
talldan
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
talldan
added
the
[Feature] Design Tools
|
@t-hamano Thanks for pointing that out, I've added it in the last commit. I noticed it makes the visualizer stop working correctly, so perhaps that needs to take box sizing into account. I'll treat that as a separate issue though. |
|
Size Change: +28 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
Actually, I think this is more related to the dynamic nature of some of the presets. Some values like this one: --wp--preset--spacing--70: clamp(5rem, 5.25rem + ((1vw - 0.48rem) * 9.096), 8rem);Might be evaluated differently because the PaddingVisualizer is rendered in a popover slot and the block itself isn't. Units like I had similar challenges in #45056, and the solution was to render the visualizer inline. |
|
Thanks for the review @t-hamano! |
|
I put a fix together for the inaccuracy of the visualizer in #49422 |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #48968
Adds spacing tools (padding, margin) to the time to read block.
Why?
See #48968
How?
Adds the spacing support properties to the block.json.
Testing Instructions
Screenshots or screencast