Adds content locking to navigation block #44739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
added
[Type] Enhancement
|
Size Change: +71 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
draganescu
force-pushed
the
fix/navigation-block-locking
branch
from
f4f02ae
to
8ff5567
Compare
draganescu
requested review from
tellthemachines,
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
talldan
reviewed
Oct 10, 2022
|
This PR now adds locking to the navigation block that I think works like all the other blocks. |
draganescu
force-pushed
the
fix/navigation-block-locking
branch
from
721581b
to
a2541fd
Compare
Adds a new block api method `isNavigationBlock` to complement `isReusableBlock`.
- removes the newly added isNavigationBlock - removes the dependency on isReusable from block locking UI Co-authored-by: George Mamadashvili <240569+Mamaduka@users.noreply.github.com>
draganescu
force-pushed
the
fix/navigation-block-locking
branch
from
30d5d7e
to
61d99b5
Compare
Mamaduka
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
Thanks for working on this, @draganescu!
I tested edit locking across browsers, and it works as expected.
Ideas for follow-up PRs. These aren't related to changes introduced here.
- Disable "Apply to all blocks inside" when only edit locking is selected.
- Disabled ability to expand blocks in the List View when the parent block has edit locking enabled.
bph
added
the
Needs Dev Note
bph
removed
the
Needs Dev Note
|
Removed the label |
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The navigation block, when locked, cannot restrict editing of contents (links and
submenus). This PR fixes this.
Why?
Because it should work at least on the same feature level as a reusable block, which
has this ability to restrict editing of contents.
How?
Copies the same way in which the reusable blocks have the feature, thus also adding
a new block api method
isNavigationBlock.Testing Instructions
contents.
Screenshots or screencast
navigation-lock-all.mp4
To do