Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment Reply Link: Add spacing support #43658

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Comment Reply Link: Add spacing support #43658

merged 1 commit into from
Sep 1, 2022

Conversation

ndiego
Copy link
Member

@ndiego ndiego commented Aug 26, 2022

Related:

What?

Add padding and margin support to the Comment Reply Link block.

Why?

To create consistency across blocks.

How?

Added the relevant block supports in block.json

Note that box-sizing: border-box was not applied to this block like in other implementations. Since the Comment Reply Link block is always contained within the Comments Template, box-sizing: border-box did not seem to be needed in my testing.

Testing Instructions

  1. Insert a new Comments Reply Link block.
  2. Confirm the Dimension control panel allows you to add both padding and margin.
  3. Adding padding and margin.

Screenshots or screencast

comment-reply-link-spacing

The visualizers in the Site Editor are a little wonky, but not related to this PR.
@ndiego ndiego added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Aug 26, 2022
@ndiego ndiego self-assigned this Aug 26, 2022
@ndiego ndiego mentioned this pull request Aug 26, 2022
Open
carolinan
carolinan approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@carolinan carolinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theme.json, global styles, and editing single blocks work well.
andrewserong
andrewserong approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is working nicely for me, too, and doesn't appear to require the box-sizing rule 👍

image

I'll merge this in and update the tracking issue.
@andrewserong andrewserong merged commit a98af8c into WordPress:trunk Sep 1, 2022
@github-actions github-actions bot added this to the Gutenberg 14.1 milestone Sep 1, 2022
@cbravobernal cbravobernal added the [Block] Comments Affects the Comments Block - formerly known as Comments Query Loop label Sep 13, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
5 participants
@ndiego @carolinan @andrewserong @femkreations @cbravobernal