Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heading: Add padding support #43454

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Heading: Add padding support #43454

merged 1 commit into from
Aug 22, 2022

Conversation

ndiego
Copy link
Member

@ndiego ndiego commented Aug 21, 2022

Related:

What?

Add padding support to the Heading block.

Why?

To create consistency across blocks. But this also potentially fixes #40144 since now users can override padding applied to Heading blocks when there is a background color.

How?

Added the relevant block support in block.json

Testing Instructions

  1. Insert a new heading.
  2. Adding Padding and configure.

Screenshots or screencast

heading-padding
@ndiego ndiego added [Type] Enhancement A suggestion for improvement. [Block] Heading Affects the Headings Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Aug 21, 2022
@ndiego ndiego self-assigned this Aug 21, 2022
@ndiego ndiego changed the title Adding padding support to headings. Aug 21, 2022
@ndiego ndiego mentioned this pull request Aug 21, 2022
Closed
glendaviesnz
glendaviesnz approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@glendaviesnz glendaviesnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well for me in post editor and global styles
@glendaviesnz glendaviesnz merged commit f4e0136 into WordPress:trunk Aug 22, 2022
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 22, 2022
@glendaviesnz glendaviesnz mentioned this pull request Aug 22, 2022
Open
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Heading Affects the Headings Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
3 participants
@ndiego @glendaviesnz @femkreations