Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Term description: add spacing block supports #43372

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Aug 18, 2022

Related:

What?

Enabling spacing support for the Term description block

Why?

To create consistency across blocks.

How?

Adding the relevant block supports in block.json

Testing Instructions

  1. Make sure you have some posts with tags or categories
  2. Load the site editor and create / edit the archive template
  3. Add a Term description block.
  4. Confirm that the dimensions control panel is there
  5. Add margin and padding.
  6. Save and go to a term's archive page, e.g., http://localhost:8888/?tag=good-tag and confirm the styles appear on the frontend.
  7. Test the new support works for the block via theme.json and global styles. See example JSON below.
	"styles": {
		"blocks": {
			"core/term-description": {
				"spacing": {
					"padding": "122px",
					"margin": "22px"
				}
			}
		}
	}

Screen Shot 2022-08-18 at 8 33 58 pm

Screen Shot 2022-08-18 at 8 45 05 pm

@ramonjd ramonjd added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Block] Term Description Affects the Term Description Block - used for displaying the description of a tag, catergory or othe labels Aug 18, 2022
@ramonjd ramonjd self-assigned this Aug 18, 2022
@apeatling apeatling self-requested a review August 18, 2022 17:32
Copy link
Contributor

@apeatling apeatling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Confirm that the dimensions control panel is there
✅ Add margin and padding.
✅ Save and go to a term's archive page, e.g., http://localhost:8888/?tag=good-tag and confirm the styles appear on the frontend.
✅ Test the new support works for the block via theme.json and global styles. See example JSON below.

@ramonjd ramonjd merged commit ed5c159 into trunk Aug 19, 2022
@ramonjd ramonjd deleted the add/term-description-spacing-block-supports branch August 19, 2022 00:41
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 19, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Term Description Affects the Term Description Block - used for displaying the description of a tag, catergory or othe [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
3 participants