Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add margin/padding support to Archives block #43350

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

tellthemachines
Copy link
Contributor

What?

Addresses part of #43243.

Why?

For consistency of design tools between blocks.

How?

Adds margin and padding supports to Archives block.

Testing Instructions

  1. Add an Archives block to a post;
  2. Check that margin/padding controls are available in the block sidebar;
  3. Change the values for margin and padding and check they work as expected on editor and front end.

Screenshots or screencast

Screen Shot 2022-08-18 at 1 41 55 pm

@tellthemachines tellthemachines added [Block] Archives Affects the Archives Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Aug 18, 2022
@carolinan
Copy link
Contributor

Tested with the spacing scale in TT3. The controls do not look the same to me as in the screenshot, instead, I see the select list. I believe that is expected since the values in the theme are custom?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Archives Affects the Archives Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs User Documentation Needs new user documentation
3 participants