[Full Site Editing]: Expand the templates that can be added - specific pages #42138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
|
Size Change: +36 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
|
The add-template menu and associated behaviours are working as expected 👍 However, I'm not seeing the template I created in the post editor template dropdown:
|
@jameskoster this is the default template in your case. You can check by trying to edit the default template. |
|
Then shouldn't I also see Side note, this highlights why we need to fix #41449 😅 |
@jameskoster do you think that is something we can handle separately in a different PR? |
|
No strong preference on where the work happens, but I'm increasingly of the opinion that 41449 is a blocker for the template expansion work going into a wp release. |
I agree it should be separate. |
mcsf
approved these changes
Jul 7, 2022
38 tasks
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #37407
This PR expands the templates that can be added by handling templates for specific
pages.How?
It uses the same design for custom post types, taxonomies etc.. that are already merged.
pageand we have available pages that don't have a specific template created, it will show a modal with two options to create either of them. You can search through the available pages to create a specific template for it.pageand we don't have available pages that don't have a specific template created, clicking the menu item will just create thepage.pageand we have available pages that don't have a specific template created, it will show the UI for searching the available pages.pageand we don't have available terms that don't have a specific template created, the menu item will not be added.Testing Instructions