Theme Export: Sort theme.json properties #39842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
the
[Feature] Themes
MaggieCabrera
approved these changes
Mar 29, 2022
aristath
approved these changes
Mar 29, 2022
scruffian
force-pushed
the
update/theme-export-ksort
branch
from
9f82df8
to
9048ee5
Compare
scruffian
force-pushed
the
update/theme-export-ksort
branch
from
9048ee5
to
5648f0c
Compare
36 tasks
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This sorts the keys of theme.json on export alphabetically.
Why?
The order of the properties on the export currently are not predictable, which means that when you export the theme.json back to an existing theme the diff doesn't match as the properties are in a different order.
How?
Uses a utility function.
Testing Instructions
Notes
I'm not sure if this is really what we want. Often the properties don't read as well in this order, but without a predictable order we will continue to have problems when creating diffs from the site editor.
cc @WordPress/block-themers