Gallery: Ensure last image takes up all available space #38189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stacimc
added
the
[Block] Gallery
stacimc
commented
Jan 24, 2022
| max-width: 100%; | ||
| // Ensure max-width is not overridden on the img when the parent gallery has | ||
| // wide or full alignment. | ||
| max-width: 100% !important; |
There was a problem hiding this comment.
This specifically was necessary for the frontend on Twenty Nineteen, to override:
@media only screen and (min-width: 768px)
.entry .entry-content .wp-block-image:not(.alignwide):not(.alignfull) > img {
max-width: calc(8 * (100vw / 12) - 28px);
As the alignfull/alignwide class is present on the container but not included on the img children.
|
Size Change: +18 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
glendaviesnz
approved these changes
Jan 24, 2022
glendaviesnz
added
the
Backport to WP Minor Release
Mamaduka
removed
the
Backport to WP Minor Release
Mamaduka
pushed a commit
that referenced
this pull request
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38156
Description
In the Gallery block, if the last row contains a single image it should scale up to use all the available space. Some theme styles for the
fullandwidealignment options were limiting the max-width of Images and preventing this from working correctly for full/wide-aligned Galleries. This PR adds amax-width: 100%to override those styles.How has this been tested?
Tested in Twenty Twenty-One, Twenty Twenty, Twenty Nineteen, Seedlet, and TT1-blocks.
For each theme:
Make sure to test Twenty Nineteen, because it has highly specific rules that target the
imgand required higher specificity to override.Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).