Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kotlin version for react-native Android projects to 1.5.32 #37970

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Update kotlin version for react-native Android projects to 1.5.32 #37970

merged 1 commit into from
Jan 26, 2022

Conversation

oguzkocer
Copy link
Contributor

Description

This PR updates the kotlin version for react-native Android projects from 1.5.20 to 1.5.32. This is a minor version update and shouldn't have any major impact on the projects. The main goal for this PR is to test the Mobile App - Automation label which will soon be used to automate opening/updating gutenberg-mobile PRs.

How has this been tested?

Manual testing for whether there are any build errors as this is a compile time change.

Types of changes

Kotlin version changes for react-native-bridge, react-native-aztec and react-native-editor Android projects.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.
@oguzkocer oguzkocer added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) Mobile App - Automation Label used to initiate Mobile App PR Automation labels Jan 14, 2022
@wpmobilebot wpmobilebot mentioned this pull request Jan 14, 2022
Closed
@oguzkocer oguzkocer marked this pull request as ready for review January 25, 2022 14:30
@hypest
Copy link
Contributor

hypest commented Jan 25, 2022

Tested the build of the demo app locally and works fine!

Opened a draft PR on WPAndroid to test things out on that side as well 👍
@SiobhyB SiobhyB self-requested a review January 26, 2022 13:47
SiobhyB
SiobhyB approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@SiobhyB SiobhyB left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @oguzkocer, Stefanos asked me if I could finish up the testing here. :)

Note: As this branch is behind trunk and missing the bridge changes introduced in #37776, it currently fails to build when testing against the latest from Android's trunk branch. I updated the branch so I could test on Android locally, but didn't commit those local changes as I didn't want to intrude on your PR. I wanted to add context as to why the Android PR didn't create an installable build, though. I'll be happy to close or update the Android PR depending on when this one gets merged.

With the updated branch, I confirmed that the app builds with no errors. I was able to open the editor and run through some of the writing flow tests with no problems.

Approving this PR, as well as the Gutenberg Mobile one at wordpress-mobile/gutenberg-mobile#4467. 🚀
@oguzkocer
Copy link
Contributor Author

Thank you @SiobhyB!
@oguzkocer oguzkocer merged commit 4ab1bab into trunk Jan 26, 2022
@oguzkocer oguzkocer deleted the update/kotlin-version-to-1.5.32 branch January 26, 2022 17:09
@github-actions github-actions bot added this to the Gutenberg 12.6 milestone Jan 26, 2022
@SiobhyB SiobhyB mentioned this pull request Jan 26, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - Automation Label used to initiate Mobile App PR Automation Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
3 participants
@oguzkocer @hypest @SiobhyB