Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Update native codeowners of various packages #37693

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

guarani
Copy link
Contributor

@guarani guarani commented Jan 3, 2022

Description

Removing myself from rich-text codeowner since I'm not monitoring the resulting notifications. The vast majority of notifications I receive as code owner are too detached from my work to be useful.

I don't think there is a requirement for finding someone else to take my place here, but let me know if you feel differently.

Types of changes

  • Update codeowners

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
Removing myself from rich-text codeowner since I'm not monitoring the resulting notifications. The vast majority of notifications I receive as code owner are too detached from my work to be useful.
@guarani guarani changed the title Update rich-text codeowners Jan 3, 2022
@guarani guarani requested a review from mchowning January 3, 2022 18:29
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Removing myself from rich-text codeowner since I'm not monitoring the resulting notifications.

Just want to confirm that you mean to leave yourself as codeowner of /packages/rich-text and /packages/block-editor/src/components/rich-text and only remove yourself as codeowner of /packages/format-library.

@guarani
Copy link
Contributor Author

guarani commented Jan 3, 2022

Thanks for catching that, @mchowning! I meant to remove myself from all three, but not remove @cameronvoell (since that seems out-of-scope here). I've update it now.

(I'd originally thought to remove myself and @cameronvoell, but then re-instated @cameronvoell and that's when the mistake happened.)

@mchowning
Copy link
Contributor

but then re-instated @cameronvoell

Any reason to leave @cameronvoell on here? I can't imagine any reason he'd still want these, and if for some reason he does we can always add him back.

Not a blocker obviously, feel free to go ahead and merge.

@guarani
Copy link
Contributor Author

guarani commented Jan 4, 2022

I don't know whether @cameronvoell found the code owner notifications useful and I'm not sure if/when he's returning to the project, so I thought it would be best to only remove myself.

@guarani guarani merged commit 5c0efdf into trunk Jan 4, 2022
@guarani guarani deleted the rnmobile/update-rich-text-code-owners branch January 4, 2022 17:39
@github-actions github-actions bot added this to the Gutenberg 12.4 milestone Jan 4, 2022
@guarani guarani changed the title [RNMobile] Update rich-text codeowners Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants