ToolsPanel: Selected ToolsPanel menu options are not persistent

[apeatling]

Prior: #41376

When using the ToolsPanel menu to select design tool options for a block, these selections are not remembered unless the value of a design tool setting has been selected. Simply setting the option as visible is not enough to persist it on block re-selection.

This GIF shows the issue:

[apeatling]

Persisting selected options has been discussed previously in #39561 (comment).

However this discussion was for persisting selected options across multiple blocks of the same type. That warrants caution, however persisting options in the same instance of a block is quite different. In my opinion this goes against user intent and expectation and should be added.

[mtias]

Curious how you'd expect it working after a reload — would you expect a non customized option you selected to show up? Holding onto the session state seems a bit superfluos to me, and I don't think it's worth the extra complexity of handling state that would persist through remounts but not through hard reloads.

[apeatling]

I don't think it is necessary to maintain state after a reload.

However, within a single session, I can see it being a confusion. I can see a user selecting the tools they need, but in the middle selecting a similar block to refer to a setting value. Then they come back to the block to find everything reset.

I haven't run in to this in my real world usage, so it is purely hypothetical on my part -- but it has been reported in the original issue.

[mtias]

I'd consider this low impact for the likely complexity it'd entail to keep track of unmounted component state. We can revisit if it becomes a wider concern.