Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show which templates use a given template part #20476

Open
mtias opened this issue Feb 26, 2020 · 14 comments
Open

Show which templates use a given template part #20476

mtias opened this issue Feb 26, 2020 · 14 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.

Comments

@mtias
Copy link
Member

mtias commented Feb 26, 2020

An interesting idea when selecting a template part is listing in its inspector controls a list of templates that are actually using it.

@mtias mtias changed the title SHow which templates use a given template part Feb 26, 2020
@mapk mapk added this to Needs design in Full site editing Mar 3, 2020
@enriquesanchez enriquesanchez self-assigned this Mar 5, 2020
@enriquesanchez
Copy link
Contributor

Here's a mockup by @shaunandrews with minor tweaks by me. It adds a basic list of templates to the sidebar.

Select Header Partial i2

@mtias do you envision this list being interactive or purely informational?

@enriquesanchez enriquesanchez moved this from Needs design to In progress in Full site editing Mar 6, 2020
@enriquesanchez enriquesanchez moved this from In progress to Needs design in Full site editing Mar 6, 2020
@shaunandrews shaunandrews added the Needs Design Feedback Needs general design feedback. label Mar 6, 2020
@shaunandrews shaunandrews moved this from Needs design to Needs design feedback in Full site editing Mar 6, 2020
@mtias
Copy link
Member Author

mtias commented Mar 8, 2020

Could be interactive.

@enriquesanchez
Copy link
Contributor

Here are a couple more ideas:

1. Show the template preview on hover:

2020-03-11 12-26-14 2020-03-11 12_27_31

2. Display a grid of previews instead:

Select Header Partial i2

I have to say that the grid of previews feels a bit overwhelming, and they're too tiny to really make much sense of them. If went with bigger thumbnails, such as a 2 x 2 grid, they end up taking too much space.

@enriquesanchez enriquesanchez removed the Needs Design Needs design efforts. label Mar 13, 2020
@MichaelArestad
Copy link
Contributor

@enriquesanchez I'm digging the approach with the visuals more. Perhaps it could use similar patterns to the mosaic view that @dwolfe was working on?

  • The title of each template could use more visual treatment to attach it to a preview.
  • Maybe 2 columns would allow a little more space for titles and breathing room for the previews.
@MichaelArestad MichaelArestad added Needs Design Needs design efforts. and removed Needs Design Feedback Needs general design feedback. labels Mar 24, 2020
@MichaelArestad MichaelArestad moved this from Needs design feedback to Needs design in Full site editing Mar 24, 2020
@mapk
Copy link
Contributor

mapk commented Mar 24, 2020

If we tried the 2x2 grid view of the templates in the sidebar, please explore showing the full template as in @dwolfe's mosaic view mentioned by @MichaelArestad, but also try just showing the top section of the template. I believe the full view of the template in the sidebar is too difficult to see. BUT just showing the top portion of a template might be enough to communicate that template to the user.

@mapk
Copy link
Contributor

mapk commented Mar 24, 2020

However!!! Based on this comment for showing the Theme (#20469 (comment)) the hover preview option feels like a great tie-in. There's a similar experience that the user doesn't need to relearn.

I do like the hover option. If we go with that experience in the navigation, let's also use it here.

@paaljoachim
Copy link
Contributor

paaljoachim commented Mar 24, 2020

One could show parts of a template below each other just like the patterns are seen in the sidebar in Gutenberg 7.7.

But hovering is a method that will end up being used in multiple places.
Example the Block Inserter showing a preview on the right side.

The difficulty with Hover is that it might not be obvious that one can hover over a text link and see a preview. Compared to showing static thumbnails.

@MichaelArestad
Copy link
Contributor

I do like the hover option. If we go with that experience in the navigation, let's also use it here.

I would say if we go with the hover route, we should do something to the list to make the template list items look actionable. Or even just more like a list.

@mtias
Copy link
Member Author

mtias commented Mar 24, 2020

This might not be feasible to list by default, it might actually be something we need to offer on demand — a button saying "find where this template part is used".

@mapk
Copy link
Contributor

mapk commented Apr 6, 2020

@enriquesanchez, can you mockup some further designs with the suggestions?

@enriquesanchez
Copy link
Contributor

Here are some iterations based on your feedback:

View templates on demand

This might not be feasible to list by default, it might actually be something we need to offer on demand — a button saying "find where this template part is used".

I thought the simplest way for achieving this was with a link. We already use this method in other sidebar panels, so it felt natural to try it here too:

Template Part Sidebar 04

The link can mention on how many templates the template part is being used. Once clicked, the templates are displayed below. (See examples below)

Mosaic View

If we tried the 2x2 grid view of the templates in the sidebar, please explore showing the full template in mosaic view

A 2x2 mosaic grid could look something like this:

Template Part Sidebar 03

also try just showing the top section of the template

And a 2x2 grid that just shows the top part of the template:

Template Part Sidebar 02

Display on hover

I would say if we go with the hover route, we should do something to the list to make the template list items look actionable

I initially was replicating the same style we use for menu items on dropdown menus that also have hover interactions...

Screen Shot 2020-04-07 at 16 12 09

...but I agree that would not be too obvious here. We could try displaying the list as links:

Template Part Sidebar 06

We'd need to define if these will just display a preview of the template whether your click or hover, or if clicking them will instead take you to the template. If clicking them will take you somewhere, then this interaction might not work on touch devices.

@MichaelArestad
Copy link
Contributor

I think having the minimal link is great. When clicked, it could open the 2x2 grid that just shows the top part of the template giving the user a set of previews.

@mapk mapk added Needs Dev Ready for, and needs developer efforts and removed Needs Design Needs design efforts. labels Apr 14, 2020
@mapk
Copy link
Contributor

mapk commented Apr 14, 2020

Sounds good to me. Let's move forward with this link that, when clicked, open a grid of templates.

Screen Shot 2020-04-13 at 8 37 28 PM

@MichaelArestad MichaelArestad moved this from Needs design to Ready to create (needs dev) in Full site editing Apr 14, 2020
@jameskoster
Copy link
Contributor

This could use a bit of a design update to account for focus mode, and potentially things like reusable blocks and navigation menus.

@jameskoster jameskoster added Needs Design Needs design efforts. and removed Needs Dev Ready for, and needs developer efforts labels Jan 25, 2022
@annezazu annezazu added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") and removed [Feature] Full Site Editing labels Jul 24, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 16, 2023
@enriquesanchez enriquesanchez removed their assignment Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
9 participants