Lesson Plans: Landing page, archive and single page layouts

[danhthong]

This PR for #153

Steps to update Lesson Plans landing page.

• Update Dashicon & select categories to show on landing page https://a.cl.ly/kpu8xe5d
• Update Dashicon & select Audiences to show on landing page https://a.cl.ly/DOudYJ92

[hlashbrooke]

This landing page looks great! Excellent work and thanks for contributing @danhthong! I will need someone from the dev team to do a code review - perhaps @adamwoodnz? - but the layout works well from my side!

One note is that this will not be set as the home page of the site, but will need to live at /lesson-plans. That means we will need to ensure this page works at that URL while maintaining the filtered lesson plans archive page that the buttons on this landing page link to. I'm unsure how to make that work, but I'm sure it can be figured out.

[hlashbrooke]

Page needs to exist at /lesson-plans while still maintaining the filtered lesson plan archive pages.

[danhthong]

Page needs to exist at /lesson-plans while still maintaining the filtered lesson plan archive pages.

@hlashbrooke I have updated as your requested to keep current url by d8783ab.

[hlashbrooke]

This works just like I expected and I'm very happy with this! Thanks for updating the PR @danhthong!

This will still need a code review before we can merge, so we need to wait on that.

[adamwoodnz]

This archive-title-prefix isn't in the Figma file.

I can see it's existing though. Do we want to keep it @courtneyr-dev @hlashbrooke ?

[danhthong]

@adamwoodnz All done. Thank you a lot!

[adamwoodnz]

@iandunn any concerns about these ignores?

[iandunn]

Technically they should have something like

if ( /* is inserting new term */ ) {
    check_admin_referer( 'add-tag', '_wpnonce_add-tag' );
} else {
    check_admin_referer( 'update-tag_' . $term_id );
}

...but in practice that should be covered by the nonce that already exists in edit-tags.php

Switching to that would be ideal IMO, but not a blocker

[adamwoodnz]

I'm seeing some odd styling on the Learn homepage cards

They appear to be missing this padding rule

Same for you @danhthong ?

[hlashbrooke]

IIRC that padding will be off for you because it is actually coming from the Customiser on the live Learn site. I will confess that I added it (along with some other custom CSS) when I wasn't able to contribute code properly but needed the styling to be done.

Now that I think of it, I'll create a new issue for moving any CSS from the Customiser into the actual theme files.

UPDATE: Added an issue here: #937

[adamwoodnz]

IIRC that padding will be off for you because it is actually coming from the Customiser on the live Learn site.

Adding this locally fixed it, thanks @hlashbrooke

I'll approve this now, and merge and deploy once I get the all clear from @iandunn.

We'll need to select the categories and audiences for the landing page cards and choose dashicons for them after deployment.

[adamwoodnz]

LGTM 🎉

[hlashbrooke]

Thanks for all the hard work here @danhthong and @adamwoodnz - this is going be great to have live!

[adamwoodnz]

Sorry @danhthong but I've found another issue with the sticky field. I don't seem to be able to un-sticky a category:

It's the same for Audiences.

[danhthong]

@adamwoodnz I updated for last issue and add check to skip phpcs ignores.

[adamwoodnz]

Works for me!