Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add locale suggestion banner #2535

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Conversation

renintw
Copy link
Contributor

@renintw renintw commented Jun 13, 2024

Closes #2428

This PR adds a locale suggestion banner to the header and front page header.

Related PRs:
WordPress/wporg-mu-plugins#626
meta.trac.wordpress.org/ticket/7675

Screenshots

Locale Homepage Other page
en-us Screenshot 2024-06-14 at 07 07 49 Screenshot 2024-06-14 at 07 07 25
ja Screenshot 2024-06-14 at 07 06 26 Screenshot 2024-06-14 at 07 07 02
zh-tw Screenshot 2024-06-14 at 07 04 10 Screenshot 2024-06-14 at 07 13 48
@renintw renintw self-assigned this Jun 13, 2024
@renintw renintw added the [Component] Learn Theme Website development issues related to the Learn theme. label Jun 13, 2024
@renintw renintw added this to the Learning Pathways launch milestone Jun 13, 2024
Copy link
Contributor

@adamwoodnz adamwoodnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Works well for me in sandbox. This has the same style as the one on the homepage (grey background), but I notice Plugins and Themes are using a shade of blueberry. Which should it be please @WordPress/meta-design ?

Screenshot 2024-06-14 at 2 00 54 PM

@jasmussen
Copy link

That's the right place for the banner for the moment 👍 👍

@renintw renintw merged commit cc5a0f3 into trunk Jun 17, 2024
1 check passed
@renintw renintw deleted the 2428-add-locale-suggestion-banner branch June 17, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Learn Theme Website development issues related to the Learn theme.
3 participants