Fix: Adjust word wrap strategy in Safari #3191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebykat
force-pushed
the
fix/safari-word-wrap
branch
from
6fd7b31
to
cef6ede
Compare
roundhill
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
We initially set the word-wrap option in Safari to "simple" rather than "advanced" because we noted performance issues with it. In some brief testing, it looks to me like the performance issues are now mitigated, so we can fix the line wrapping in Safari. Putting this in its own PR in case we do find that it causes issues.
Will fix #2805
Test
Open some long notes in Safari and verify that word wrap is no longer awkwardly early and also that it does not freeze the browser or cause long load times.