Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connections-wizard): error display #2836

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

adekbadek
Copy link
Member

@adekbadek adekbadek commented Jan 5, 2024

All Submissions:

Changes proposed in this Pull Request:

Fixes an issue with false-positive error display in the Connections wizard.

See 1200550061930446-as-1206088853297652

How to test the changes in this Pull Request:

  1. On master,
  2. Mock the Google OAuth status response by returning early from Google_OAuth::api_google_auth_status – start with a success message (return \rest_ensure_response($response)
  3. Load the Connections wizard, observe a Google: undefined error notice at the top of the view
  4. Switch to this branch
  5. Reload the wizard, observe no error
  6. Mock an error response (return new \WP_Error(…)), observe it correctly displayed in the wizard

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek added the [Status] Needs Review The issue or pull request needs to be reviewed label Jan 5, 2024
@adekbadek adekbadek requested a review from a team as a code owner January 5, 2024 12:07
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jan 8, 2024
@adekbadek adekbadek merged commit 7b20899 into master Jan 9, 2024
7 checks passed
@adekbadek adekbadek deleted the fix/connections-error-handling branch January 9, 2024 09:49
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.14.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.15.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.16.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
3 participants