fix(renderer): ensure group blocks use conditional tags #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[Status] Approved
matticbot
pushed a commit
that referenced
this pull request
Jan 11, 2024
# [2.9.0-alpha.1](v2.8.0...v2.9.0-alpha.1) (2024-01-11) ### Bug Fixes * memberships & "other" ESP ([6e0402c](6e0402c)) * prevent the use of `add_contact` for data sync purposes ([#1386](#1386)) ([2d68c1f](2d68c1f)) * **renderer:** ensure group blocks use conditional tags ([#1380](#1380)) ([a1a9722](a1a9722)) * store and recover lists on membership reactivation ([#1377](#1377)) ([aa8a8f4](aa8a8f4)) ### Features * display warning if custom fields meta box is visible ([d595ed4](d595ed4)) * **tracking:** support UTM coming from the ESP ([#1388](#1388)) ([77d3a1e](77d3a1e))
|
🎉 This PR is included in version 2.9.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Jan 25, 2024
# [2.9.0](v2.8.3...v2.9.0) (2024-01-25) ### Bug Fixes * add lodash as dependency for editor.js ([c01aebb](c01aebb)) * memberships & "other" ESP ([6e0402c](6e0402c)) * prevent the use of `add_contact` for data sync purposes ([#1386](#1386)) ([2d68c1f](2d68c1f)) * **renderer:** ensure group blocks use conditional tags ([#1380](#1380)) ([a1a9722](a1a9722)) * store and recover lists on membership reactivation ([#1377](#1377)) ([aa8a8f4](aa8a8f4)) ### Features * display warning if custom fields meta box is visible ([d595ed4](d595ed4)) * **tracking:** support UTM coming from the ESP ([#1388](#1388)) ([77d3a1e](77d3a1e))
|
🎉 This PR is included in version 2.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
1200550061930446-as-1205996773681761
Group blocks placed in the root of the body are processed outside the usual
render_mjml_component()method so they didn't have the conditional tags properly applied.This PR ensures the conditional tags are rendered for such blocks.
How to test the changes in this Pull Request:
*|IF:FNAME|*and*|END:IF|*Other information: