Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add event queue debug #34

Merged
merged 4 commits into from
Jan 25, 2024
Merged

feat: add event queue debug #34

merged 4 commits into from
Jan 25, 2024

Conversation

leogermani
Copy link
Contributor

@leogermani leogermani commented Jan 15, 2024 •
edited
Loading

Adds a debug section that shows the events that are scheduled to be sent from the Node to the Hub

Testing

Perform some actions in the Node, like registering with a new user, or editing a user profile in admin.

Go to Newspack Network > Node Settings and see the new "Events queue" section. Confirm the events are there, scheduled to be sent

Captura de tela de 2024-01-15 12-42-12

Force some errors, by setting a wrong URL to the Hub, or making the Hub not accessible.

Perform a new action and wait for it to display errors

Captura de tela de 2024-01-15 12-42-35

Note 1: Not adding a "Send now" button at this moment
@leogermani leogermani self-assigned this Jan 15, 2024
@leogermani leogermani requested a review from a team as a code owner January 15, 2024 16:06
miguelpeixe
miguelpeixe approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@miguelpeixe miguelpeixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new table is working great!

Non-blocking, but I'm not sure about the use of the term "queue" here. The webhook request doesn't behave like a queue. They are independent and process whenever they can, e.g., if there's a hiccup and the webhook request is scheduled to try again in a couple of minutes, a later request might run sooner. How about "Event history"?
@leogermani
Copy link
Contributor Author

How about "Event history"

Hmm it's not history because the have not been sent yet

  • Events waiting room
  • Events outbox

or simply "Recent Events"

and also change "queued" with "scheduled" in the paragraph there
@miguelpeixe
Copy link
Member

I like "Scheduled events" even if it still shows the most recent sent events.
@leogermani
Copy link
Contributor Author

I like "Scheduled events" even if it still shows the most recent sent events.

6200fbf
miguelpeixe
miguelpeixe approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@miguelpeixe miguelpeixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@leogermani leogermani merged commit a5e48ae into master Jan 25, 2024
3 checks passed
matticbot pushed a commit that referenced this pull request Jan 25, 2024
@semantic-release-bot
chore(release): 1.1.0-alpha.1 [skip ci]
5bca484 
# [1.1.0-alpha.1](v1.0.1...v1.1.0-alpha.1) (2024-01-25)

### Bug Fixes

* add workaround for distributor bug ([#36](#36)) ([123ac89](123ac89))

### Features

* add event queue debug ([#34](#34)) ([a5e48ae](a5e48ae))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.1.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀
matticbot pushed a commit that referenced this pull request Jan 25, 2024
@semantic-release-bot
chore(release): 1.1.0 [skip ci]
2541b7f 
# [1.1.0](v1.0.1...v1.1.0) (2024-01-25)

### Bug Fixes

* add workaround for distributor bug ([#36](#36)) ([123ac89](123ac89))

### Features

* add event queue debug ([#34](#34)) ([a5e48ae](a5e48ae))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @alpha released [Status] Needs Review
3 participants
@leogermani @miguelpeixe @matticbot