Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate schedule_event filter #244

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Validate schedule_event filter #244

merged 1 commit into from
Jan 12, 2022

Conversation

WPprodigy
Copy link
Contributor

WP core kinda set a precedent for this filter being used as a mechanism for preventing events to be scheduled, as various plugins will return false. So safeguarding against that and any other filter weirdness.

Currently seeing fatals like this as a result:

PHP Fatal error:  Uncaught TypeError: Argument 1 passed to Automattic\WP\Cron_Control\Event::set_action() must be of the type string, null given, called in /var/www/wp-content/mu-plugins/cron-control/includes/wp-adapter.php on line 70 and defined in /var/www/wp-content/mu-plugins/cron-control/includes/class-event.php:77
@WPprodigy
Copy link
Contributor Author

Oh meant to link this for context: https://github.com/WordPress/WordPress/blob/92f0b0cb48a3de660655cc658fc739695a393096/wp-includes/cron.php#L165-L192
@WPprodigy WPprodigy merged commit 4a9ddbd into master Jan 12, 2022
@WPprodigy WPprodigy deleted the fix/validate-schedule-event-filter branch January 12, 2022 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@WPprodigy @rinatkhaziev