Get WordPress

Make WordPress Core

Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#61199 closed enhancement (fixed)

Make Settings API documentation link clickable in options.php

Reported by: timse201's profile timse201 Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.6 Priority: normal
Severity: normal Version: 3.0
Component: Options, Meta APIs Keywords: good-first-bug has-patch needs-testing
Focuses: ui, administration Cc:

Description

in the options.php under line 325 there is a non-clickable link

The %s setting is unregistered. Unregistered settings are deprecated. See ​https://developer.wordpress.org/plugins/settings/settings-api/

Attachments (1)

patch.diff​ (790 bytes) - added by amitraj2203 3 months ago.
Patch file.

Download all attachments as: .zip

Change History (9)

#1 @sabernhardt
3 months ago

  • Component changed from General to Administration
  • Focuses accessibility removed
  • Keywords needs-patch added; changes-requested removed
  • Milestone changed from Awaiting Review to Future Release
  • Summary changed from no clickable link under options.php:325 to Make Settings API documentation link clickable in options.php
  • Version changed from trunk to 3.0

Hi and welcome to WordPress Core Trac!

I suggest
See <a href="https://developer.wordpress.org/plugins/settings/settings-api/">documentation on the Settings API</a>.

The link has been plain text since [13785] (with updates in [14070], [32116], [34315], and [45674]).

#2 @SergeyBiryukov
3 months ago

  • Keywords good-first-bug added
  • Milestone changed from Future Release to 6.6

@amitraj2203
3 months ago

Patch file.

#3 @amitraj2203
3 months ago

Hi @sabernhardt I have submitted the patch for the same.

#4 @khokansardar
3 months ago

  • Keywords has-patch needs-testing added; needs-patch removed

#5 @SergeyBiryukov
3 months ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#6 @SergeyBiryukov
3 months ago

  • Component changed from Administration to Options, Meta APIs

#7 @SergeyBiryukov
3 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 58140:

Docs: Make Settings API documentation link clickable in wp-admin/options.php.

The link is a part of the deprecation notice displayed when saving an unregistered setting.

Follow-up to [13646], [13785], [14070], [32116], [34315], [45674].

Props timse201, sabernhardt, amitraj2203, khokansardar, SergeyBiryukov.
Fixes #61199.

#8 @sabernhardt
3 months ago

Yes, separating the URL from the text string can be good, especially if/when the documentation URL changes again in the future.

Note: See TracTickets for help on using tickets.